Don't trim non-ASCII whitespace#289
Merged
jgm merged 1 commit intocommonmark:masterfrom Sep 23, 2024
Merged
Conversation
tats-u
force-pushed
the
trim-only-ascii-space
branch
2 times, most recently
from
21d88d5 to
32e9f5c
Compare
tats-u
force-pushed
the
trim-only-ascii-space
branch
from
32e9f5c to
2428626
Compare
4 tasks
This was referenced Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #261
.trim()removes non-ascii Unicode white spaces as well.https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/trim
cmark removes NBSP, but is this an expected behavior?(
?means U+2003 can't be converted to Shift_JIS, which is the OEM encoding in Japanese Windows.)