Skip to content

Conversation

@HarikalarKutusu
Copy link
Contributor

This adds Laz language variants and accents.
PR is for İsmail Bucaklisi
For review by @ftyers

Variants and accents are ordered from west to east.

image

@HarikalarKutusu HarikalarKutusu requested a review from a team as a code owner February 11, 2025 18:25
@HarikalarKutusu HarikalarKutusu requested review from moz-dfeller and removed request for a team February 11, 2025 18:25
Copy link
Contributor

@moz-kathyreid moz-kathyreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firstly, many thanks @HarikalarKutusu as always for your dedication and for preparing this PR - we really appreciate it!

I performed the following checks to review this PR

  • Ran the accents.ts and variants.ts raw Typescript through the Typescript linter at https://typescript-eslint.io to check for any errant commas or malformed JSON => All OK

  • Manual check of Variants to check they have names in language and an appropriate BCP-47 subtag => all OK

  • Manual check of Accents to check they have appropriate accent_name and accent_token => all OK

  • I pulled in the PR into main on my local development version and inspected accents.ts and variants.ts => all OK

  • Checked database with PR checked out:

SELECT l.name, l.native_name, v.variant_name, v.variant_token 
FROM variants v, locales l
WHERE v.locale_id = l.id 
AND l.name = 'lzz'
name native_name variant_name variant_token
lzz Lazuri Atinuri, Artaşenuri lzz-atinuri
lzz Lazuri Vitzuri, Arkaburi lzz-arkaburi
lzz Lazuri Xopuri lzz-xopuri
SELECT l.name, l.native_name, a.accent_name, a.accent_token 
FROM accents a, locales l
WHERE a.locale_id = l.id 
AND l.name = 'lzz' 
name native_name accent_name accent_token
lzz Lazuri unspecified
lzz Lazuri Arkabi (Arhavi) arkaburi
lzz Lazuri Artaşeni (Ardeşen) artaşenuri
lzz Lazuri Atina (Pazar) atinuri
lzz Lazuri Beğlevani (Güreşen) beğlevanuri
lzz Lazuri Çxala (İçkale/Borçka) çxaluri
lzz Lazuri Vitzi (Fındıklı) vitzuri
lzz Lazuri Xope (Hopa) xopuri
  • The one check I wanted to do but was unable was to add the lzz language to my profile in my local development version, then make sure that I had the Variants and Accents available when adding a sentence. In my development environment there is no lzz language to import. I suspect this is because the language hasn't launched yet and the lzz sentences are not available for importing.

This LGTM, approving for merge.
Once again many thanks @HarikalarKutusu and very best wishes for all your work on Circassian languages.

@moz-kathyreid moz-kathyreid merged commit 6788e64 into common-voice:main Mar 5, 2025
2 checks passed
@moz-kathyreid moz-kathyreid added the Variant A language variant request or issues related to language variants label Mar 5, 2025
@HarikalarKutusu HarikalarKutusu deleted the add-laz-variants-accents branch March 5, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Variant A language variant request or issues related to language variants

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants