Skip to content

Revert "Upgrade to aeson 2.0, closes #6217"#6437

Merged
mihaimaruseac merged 1 commit intomasterfrom
revert-6334-aeson-2.0
Feb 7, 2022
Merged

Revert "Upgrade to aeson 2.0, closes #6217"#6437
mihaimaruseac merged 1 commit intomasterfrom
revert-6334-aeson-2.0

Conversation

@mihaimaruseac
Copy link
Member

Reverts #6334

Reverting as it creates cyclic deps which I don't know yet how to resolve. Will revert again when I do.

In the dependencies for criterion-1.5.13.0:
    aeson dependency cycle detected: aeson, criterion, base16-bytestring, aeson, Agda
needed since criterion is a build target.

In the dependencies for criterion-measurement-0.1.3.0:
    aeson dependency cycle detected: aeson, criterion, base16-bytestring, aeson, Agda
needed since criterion-measurement is a build target.

In the dependencies for microstache-1.0.2:
    aeson dependency cycle detected: aeson, criterion, base16-bytestring, aeson, Agda
needed since microstache is a build target.

In the dependencies for statistics-0.16.0.1:
    aeson dependency cycle detected: aeson, criterion, base16-bytestring, aeson, Agda
needed since statistics is a build target.

@mihaimaruseac mihaimaruseac merged commit 5eaa01a into master Feb 7, 2022
@mihaimaruseac mihaimaruseac deleted the revert-6334-aeson-2.0 branch February 7, 2022 15:20
@bergmark
Copy link
Member

bergmark commented Feb 7, 2022

@mihaimaruseac did you try adding criterion to skipped benchmarka?

@mihaimaruseac
Copy link
Member Author

It was already there. I'll redo adc5830 and add aeson too and then after this builds (hopefully it should), I'll start removing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants