Skip to content

add greskell, greskell-core and greskell-websocket packages. #3758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bergmark merged 1 commit into from
Jun 23, 2018
Merged

add greskell, greskell-core and greskell-websocket packages. #3758

bergmark merged 1 commit into from
Jun 23, 2018

Conversation

@debug-ito
Copy link
Contributor

@debug-ito debug-ito commented Jun 22, 2018

Confirmed with stackage nightly.

Note that greskell-core depends on containers but it doesn't support containers-0.6 yet. I don't think that is a problem with stackage for now, but correct me if I'm wrong.

@bergmark
Copy link
Member

bergmark commented Jun 22, 2018

i can check whether we can re-enable doctest-discover once i get back to my compiter

@debug-ito
Copy link
Contributor Author

debug-ito commented Jun 22, 2018

Thanks!

@bergmark
Copy link
Member

bergmark commented Jun 23, 2018

Looks good, thanks!

@bergmark bergmark merged commit 7d541e2 into commercialhaskell:master Jun 23, 2018
@bergmark
Copy link
Member

bergmark commented Jun 23, 2018

Some of the greskell tests are failing, is this expected?

Split typeclass
  Filter -> Filter FAILED [1]
  Filter -> Transform FAILED [2]
  Filter -> SideEffect FAILED [3]
  Transform -> Filter FAILED [4]
  Transform -> Transform FAILED [5]
  Transform -> SideEffect FAILED [6]
  SideEffect -> Filter
  SideEffect -> Transform
  SideEffect -> SideEffect FAILED [7]
Lift typeclass
  Filter -> Filter FAILED [8]
  Filter -> Transform FAILED [9]
  Filter -> SideEffect FAILED [10]
  Transform -> Filter
  Transform -> Transform FAILED [11]
  Transform -> SideEffect FAILED [12]
  SideEffect -> Filter
  SideEffect -> Transform
  SideEffect -> SideEffect FAILED [13]

Failures:

  test/HintTest.hs:53:7:
  1) Split typeclass Filter -> Filter
       expected: True
        but got: False

  test/HintTest.hs:53:7:
  2) Split typeclass Filter -> Transform
       expected: True
        but got: False

  test/HintTest.hs:53:7:
  3) Split typeclass Filter -> SideEffect
       expected: True
[...]

@debug-ito
Copy link
Contributor Author

debug-ito commented Jun 23, 2018

No it's not.

They test if Split and Lift typeclasses allow only for certain pairs of types. We use hint to check some pairs pass compile and other pairs don't. However, the test results you showed seems like all pairs fail to compile. I'm not sure why.

I think those tests are tricky and probably unstable. Maybe we should disable hint-test flag on greskell to disable the tests (the flag is enabled by default.)

bergmark added a commit that referenced this pull request Jun 23, 2018
@bergmark
Disable greskell hint tests #3758
df33454
@bergmark
Copy link
Member

bergmark commented Jun 23, 2018

Ok thanks, I'll try that.

@bergmark
Copy link
Member

bergmark commented Jun 23, 2018

It seems like it worked now!

But I'd recommend adding manual: True to that flag, otherwise cabal-install (maybe also the stackage build server, I'm not sure) may toggle it automatically if, for example, there are dependency issues.

debug-ito added a commit to debug-ito/greskell that referenced this pull request Jun 24, 2018
@debug-ito
greskell.cabal: add 'manual: True' to hint-test flag.
25e6b7f 
See commercialhaskell/stackage#3758
@debug-ito
Copy link
Contributor Author

debug-ito commented Jun 24, 2018

Thanks for the advice. I added manual: True option in greskell-0.2.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@debug-ito @bergmark