Fix how cpp-options are passed to ghci wrt #5532 #5608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-DFOO options can be passed directly to ghc, but cpp-options may include flags for the preprocessor, so we need to pass it via -optP.
Contributor
Author
|
Is there anything missing here? |
Closed
nh2
approved these changes
May 19, 2022
Collaborator
nh2
left a comment
nh2
left a comment
There was a problem hiding this comment.
This looks right to me. Haskell-C-preprocessor options should not be passed to GHC without -optP.
Contributor
Author
Member
|
It looks right to me too. I'll merge it. |
mpilgrem
added a commit
that referenced
this pull request
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-DFOOoptions can be passed directly to ghc, butcpp-options may include flags for the preprocessor,
such as
-std=c99, so we need to pass it via-optP.Fixes #5532
@fendor