Fixed a bug with ignoring cpPkg and cpCompiler fields.
#5597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snoyberg
requested changes
Aug 9, 2021
Contributor
snoyberg
left a comment
snoyberg
left a comment
There was a problem hiding this comment.
Looks great, thanks! Would you mind adding a ChangeLog entry for this bug fix?
Haskell-mouse
force-pushed
the
Fix-ghc-path
branch
from
f46012e to
bafa31c
Compare
Haskell-mouse
force-pushed
the
Fix-ghc-path
branch
from
bafa31c to
25f3253
Compare
Contributor
Author
Thanks. I've added a short note to the |
snoyberg
approved these changes
Aug 10, 2021
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like a user can't override location
ghcandghc-pkg, because these options are ignored inensureConfig.I prefer to leave
findExecutablechecking and I've just removed obviously mistaken adding "--with-ghc/ghc-pkg=" to the path.