Add a new option for custom preprocessor extensions #5490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The build failures seem to be unrelated to my changes. Should I try to fix them anyways? |
Contributor
Author
|
How often do you usually release new versions of stack? I'm curious about approximately when I can expect this to be in an official release? |
Contributor
|
We're typically pretty slow on the releases, maybe every 6-12 months. But since we just added support for GHC 9, we can probably do this one pretty soon. I'll ping internally. |
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just having a hard-coded list of preprocessor extensions, this adds a configuration option for custom preprocessor extensions.
Fixes #3491 as suggested in #3491 (comment)
TODO:
Please also shortly describe how you tested your change. Bonus points for added tests!
I have manually tested the option on an external repo. It updates on changes as expected.