Merged
Conversation
snoyberg
force-pushed
the
static-linux
branch
2 times, most recently
from
8983f2d to
2db6983
Compare
snoyberg
force-pushed
the
static-linux
branch
2 times, most recently
from
b6860df to
88bd6cd
Compare
Contributor
Author
|
Contributor
Author
|
This all works perfectly.... except that the executable in the Linux artifact segfaults!?! Investigating... |
Contributor
Author
|
It was the stripping! 4a53af2 |
Contributor
Author
|
Not sure why stripping a static executable makes it segfault, but other than that this is ready for review and potential merge. |
borsboom
reviewed
Apr 21, 2020
Contributor
Author
|
New version ready for review. I'd like to rebase before merge; let me know if you'd rather I rebase before your next review. |
borsboom
reviewed
Apr 22, 2020
Contributor
Author
|
Thanks for the review, looks like we've hit all comments. I'm going to rebase, and then merge once CI passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!