Don't change directories when cloning a repo #4862
Conversation
|
I've included a Changelog update in what I think was the right place, and I believe no documentation update is necessary (already-documented behavior now works better). |
snoyberg
left a comment
snoyberg
left a comment
There was a problem hiding this comment.
In addition to the inline comments:
- I see that there's a CI failure from the style checker
- It may make sense to PR this against the
stablebranch instead ofmaster
ChangeLog.md
Outdated
| [#4292](https://github.com/commercialhaskell/stack/issues/4292) | ||
| * Fix for git packages to update submodules to the correct state. See | ||
| [#4314](https://github.com/commercialhaskell/stack/pull/4314) | ||
| * Fix to allow dependencies on specific versions of local git repositories. See |
There was a problem hiding this comment.
This should go in "unreleased changes" instead. It should also likely be mentioned in the pantry changelog.
| -- ENABLE_VIRTUAL_TERMINAL_PROCESSING flag for native terminals. The | ||
| -- folowing hack re-enables the lost ANSI-capability. | ||
| when osIsWindows $ void $ liftIO $ hSupportsANSIWithoutEmulation stdout | ||
| runCommand ["clone", T.unpack url, dir] |
There was a problem hiding this comment.
Please add a comment that this is intentionally not run within the withWorkingDir below in order to allow relative paths to work.
amalloy
force-pushed
the
master
branch
2 times, most recently
from
b90cf52 to
356c662
Compare
|
The hlint failure was on unmodified code in a different file; I'm not inclined to touch that as part of this PR. I've adjusted the target branch, and made the changes you requested, except: the |
Right, that's intended: |
This was making it impossible to use relative file paths as repo URLs.
|
Done. |
snoyberg
left a comment
snoyberg
left a comment
There was a problem hiding this comment.
LGTM. I've merged in the changes on stable so CI will pass. This is good to merge once CI goes green.
2 participants
This was making it impossible to pin to a specific commit when using relative file paths as repo URLs.
Please include the following checklist in your PR:
I tested this change by running
stack testthree times: