-
Notifications
You must be signed in to change notification settings - Fork 847
Add the interleaved-output option/config value #3225 #4097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note that there are some subtle UX choices to be made in
These are easy changes to make in the code, it's really a design issue. And I'd rather get the design right the first time around, so bikeshed away. |
5b4a683 to
b532cc8
Compare
|
LGTM! 👍 👍 To me it seems consistent to dump output for non-local and single packages with this flag set. It would be good to have a way of suppressing such output for non-project packages, though, since the user does not have direct control over resolving errors / what is included in the output. |
nh2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and works well!
I've also tested the following:
.stack-work/install/x86_64-linux/lts-11.6/8.2.2/bin/stack --stack-root $PWD/tmpstackroot --work-dir tmpworkdir build lens --interleaved-output- equivalent
stack install - running with
2>&1 - redirecting with
teeand2>outfile
ChangeLog.md
Outdated
| the resulting tarball to the specified directory. | ||
| * Introduced the `--interleaved-output` command line option and | ||
| `build.interleaved-output` config value which causes multiple concurrent | ||
| builds to dump to stdout at the same time with a `packagename> ` prefix. See |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have observed it to dump to stderr instead of stdout.
These look like good choices to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you also want to update
the section that still says
By default, when building multiple target packages, the output from these will end up in a log file instead of on the console unless it contains errors or warnings, to avoid problems of interleaved output and decrease console noise.
For example with
Alternatively, you can pass `--interleaved-output` to see output of all packages being built scroll by in a streaming fashion.
|
Why does adding |
Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!
Manual experimentation only, sorry.