Fix --no-rerun-tests #3770
Fix --no-rerun-tests #3770
Conversation
|
I'd like to fix this one, it looks easy. Please ping if somebody else is already working on it :) |
|
Not that I'm aware of, go for it!
…On Wed, Jan 24, 2018, 3:38 AM Artyom Kazak ***@***.***> wrote:
I'd like to fix this one, it looks easy. Please ping if somebody else is
already working on it :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3770 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADBBzB0o5G-BXf2r9lvPrVAn_v0q0jeks5tNomMgaJpZM4Rdlms>
.
|
|
Okay, this is when it broke: d501148#diff-890614cc04afa326f5d48aac897e4aa8L1270 @mgsloan what was the rationale for removing the call to |
|
@snoyberg by the way, can I get write access? (To be able to push a fix to the same branch where the failing test is) |
|
Good find! And write access granted. |
|
Also, you should probably rebase this. And since it looks to be a relatively small patch, putting it on the stable branch is probably worthwhile. |
Demonstrates that --no-rerun-tests does not work, and tests are in fact still rerun.
|
@neongreen Impressed that you found the commit that caused this, my mistake! It was 2 years ago, I don't recall why that change ended up in the commit. |
neongreen
force-pushed
the
no-rerun-tests
branch
from
ea90952 to
ddad2df
Compare
|
Alright, the test passes for me (at least locally) – waiting for CI to run all integration tests |
|
Is the Travis failure okay? I'm not sure – seems to be a missing script, not a problem with this PR. If yes, I'll add a changelog entry and merge this PR (barring any other objections). |
|
I'm pretty sure Travis just got confused, and did a merge with master instead of stable. Since the push Travis job succeeded, I think it's OK to do the changelog update and then merge. |
neongreen
force-pushed
the
no-rerun-tests
branch
from
ddad2df to
39ff251
Compare
Demonstrates that --no-rerun-tests does not work, and tests are in fact
still rerun.
NOTE DO NOT MERGE yet. We still need to fix this, the test case just fails for now.
Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!