Revert "Clean up --only-dependencies logic in ConstructPlan" #3495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d1e6c48.
Contributor
|
Hmm, I guess I did not consider the logic fully when implementing that change. My bad! The logic there is still rather confusing, but if this fixes the current case, then seems reasonable. Thanks for tracking it down! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d1e6c48 and resolves #3476
The problem is caused specifically in the
PSFiles -> Nothingbranch ofinstallPackages.As the flag was no longer being passed through, packages were not being checked for being in the wanted map. This led to the local packages being built as dependencies
Please include the following checklist in your PR:
I tested this by running
stack --only-dependencies --dry-runon our stack project with multiple packages. Setting the call toresolveDepsAndInstall'streatAsDepvalue toTruecauses the problem and removing it removes the problem