Skip to content

Conversation

@snoyberg
Copy link
Contributor

@sjakobi
Copy link
Member

sjakobi commented Oct 3, 2016

Noob question: Does it matter that S3 serves the file with Content-Type: binary/octet-stream while stackage used Content-Type: application/json; charset=utf-8?

A changelog entry would be good too, but I can add one myself.

@sjakobi
Copy link
Member

sjakobi commented Oct 3, 2016

Oh, and the Travis failure can be ignored. The compile failure was introduced elsewhere and has since been fixed.

@mgsloan mgsloan merged commit b39a070 into master Oct 4, 2016
@mgsloan
Copy link
Contributor

mgsloan commented Oct 4, 2016

LGTM!

@snoyberg
Copy link
Contributor Author

snoyberg commented Oct 4, 2016

It won't break this, but it's worth fixing anyway, I'll add a note for
myself.

On Tue, Oct 4, 2016, 4:49 AM Michael Sloan [email protected] wrote:

LGTM!


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2653 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADBB632Pl7gym6vJzq3QIf8gASAjX5Uks5qwbDBgaJpZM4KK17U
.

@sjakobi sjakobi deleted the snapshots-from-s3 branch October 6, 2016 09:17
sjakobi added a commit that referenced this pull request Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants