Use package-id arg to stack ghc/runghc instead of package name #2497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This looks mostly good to me, and the fix idea and new code is probably good. Only one concern: would you mind separating the behavior-preserving refactoring from the behavioral change, and document them as such? (That is, the refactoring should declare itself as such, since one can't tell from looking at the diff). |
So that we can use the installed package-ids to prepare the ghc command (to be done in the next commit). This commit does not change behavior.
Current mechanism of using GHC_PACKAGE_PATH for runghc and ghc commands does not seem to work well when we have multiple versions of the same package. GHC does not always pick up the packages in the same order as GHC_PACKAGE_PATH. This fix determines the package-ids using ghc-pkg and then passes package-ids on command line of ghc or runghc invocation. This works only when the user explicitly passes --package to runghc or ghc commands. When --package is not specified we have no easy way to determine what all packages will be used by the file being compiled. This will make sure that scripts which explicitly list all packages will always run reliably even in presence of packages which have multiple instances of the same version or multiple versions installed. fixes #1957 (Requires all packages to be listed explicitly)
harendra-kumar
force-pushed
the
self-contained-scripts
branch
from
e98957c to
1aecd68
Compare
Collaborator
Author
|
The CI failure does not seem to have anything to do with the change. |
Collaborator
|
Failure seems indeed spurious (seen this before). LGTM & merging. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current mechanism of using GHC_PACKAGE_PATH for runghc and ghc commands does
not seem to work well when we have multiple versions of the same package. GHC
does not always pick up the packages in the same order as GHC_PACKAGE_PATH.
This fix determines of the package-ids using ghc-pkg and then passes
package-ids on command line of ghc or runghc invocation. This works only when
the user explicitly passes --package to runghc or ghc commands. When --package
is not specified we have no easy way to determine what all packages will be
used by the file being compiled.
This will make sure that scripts which explicitly list all or multi-instance
packages will always run reliably.
fixes #1957 (Requires all packages to be listed explicitly)