Clone recursively #1852
Merged
Clone recursively #1852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Stack/Config.hs
Outdated
| [ "clone" | ||
| readInNull (parent dirTmp) commandName menv $ | ||
| "clone" : cloneArgs ++ [ | ||
| , T.unpack url |
Contributor
There was a problem hiding this comment.
typo here; don't want that leading , (this caused the builds to fail)
Author
|
Whoops—my bad! |
Author
|
Oof. My bad again. Excuse me while I correct this. |
Author
|
There we go, green builds. |
Contributor
|
Thanks! Can you please squash this into one commit? |
Add the arguments to the list. Note recursive clones in the changelog. Remove leading comma. Parenthesize. Format across lines.
Author
|
Consider it squashed. |
Contributor
|
LGTM, Thanks!! |
Author
|
🙇 Thank you! |
Contributor
|
Thanks! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gitpackages using submodules may need to be cloned recursively.clonecommand on a case-by-case basis.--recursiveoption togit clone.hg clonewill already clone subrepos.I have not added a configuration option to control this, because it doesn’t seem particularly useful in the context of repos which are Haskell packages.
Fixes #1764.