Skip to content

Remove System.Linq.Expressions dependency.#764

Merged
ericnewton76 merged 1 commit into
commandlineparser:developfrom
NN---:remove_expression
May 12, 2022
Merged

Remove System.Linq.Expressions dependency.#764
ericnewton76 merged 1 commit into
commandlineparser:developfrom
NN---:remove_expression

Conversation

@NN---

@NN--- NN--- commented Jun 26, 2021

Copy link
Copy Markdown
Contributor

The code is much simpler and it allows porting library to older framework.
theraot/Theraot#157.

@NN--- NN--- force-pushed the remove_expression branch from b9e6a18 to 31895f1 Compare June 27, 2021 15:37
@NN---

NN--- commented Oct 27, 2021

Copy link
Copy Markdown
Contributor Author

@moh-hassan Any update ?

@ericnewton76 ericnewton76 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a SystemLinqExpressions nuget package that could be removed too?

nvm I see whats going on

@ericnewton76 ericnewton76 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good change, but I cant readily see the impact the change will make. I'm a little worried about merging it but I think it'll work.

@ericnewton76 ericnewton76 merged commit af75319 into commandlineparser:develop May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants