Skip to content

Commit b57558a

Browse files
mcpiercemcpierce
committed
Added a unified index for loading comics by filter [#2318]
1 parent 4b6ca73 commit b57558a

File tree

5 files changed

+35
-284
lines changed

5 files changed

+35
-284
lines changed

‎comixed-model/src/main/resources/db/migrations/2.3/014_2318_add_comic_details_filtered_index.xml‎

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
3+
<databaseChangeLog xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
4+
xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
5+
xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.1.xsd">
6+
<changeSet id="014_2318_add_comic_details_filtered_index.xml" author="mcpierce">
7+
8+
<preConditions onFail="MARK_RAN">
9+
<not>
10+
<indexExists tableName="comic_details" indexName="comic_details_example_search_idx"/>
11+
</not>
12+
</preConditions>
13+
14+
<dropIndex tableName="comic_details" indexName="comic_details_added_date_idx"/>
15+
<dropIndex tableName="comic_details" indexName="comic_details_archive_type_idx"/>
16+
<dropIndex tableName="comic_details" indexName="comic_details_comic_state_idx"/>
17+
<dropIndex tableName="comic_details" indexName="comic_details_comic_type_idx"/>
18+
<dropIndex tableName="comic_details" indexName="comic_details_cover_date_idx"/>
19+
<dropIndex tableName="comic_details" indexName="comic_details_issue_number_idx"/>
20+
<dropIndex tableName="comic_details" indexName="comic_details_load_comic_detail_list_idx"/>
21+
22+
<createIndex tableName="comic_details" indexName="comic_details_filtered_idx">
23+
<column name="cover_date"/>
24+
<column name="archive_type"/>
25+
<column name="comic_type"/>
26+
<column name="comic_state"/>
27+
<column name="publisher"/>
28+
<column name="series"/>
29+
<column name="volume"/>
30+
<column name="issue_number"/>
31+
</createIndex>
32+
33+
</changeSet>
34+
</databaseChangeLog>

‎comixed-model/src/main/resources/db/migrations/2.3/changelog-2.3.xml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,6 @@
1919
<include file="/db/migrations/2.3/011_2290_added_organizing_comics_view.xml"/>
2020
<include file="/db/migrations/2.3/012_2025_added_duplicate_pages_view.xml"/>
2121
<include file="/db/migrations/2.3/013_2292_added_displayable_comics_view.xml"/>
22+
<include file="/db/migrations/2.3/014_2318_add_comic_details_filtered_index.xml"/>
2223

2324
</databaseChangeLog>

‎comixed-services/src/main/java/org/comixedproject/service/comicbooks/ComicDetailExampleBuilder.java‎

Lines changed: 0 additions & 133 deletions
This file was deleted.

‎comixed-services/src/main/java/org/comixedproject/service/comicbooks/ComicDetailService.java‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import org.comixedproject.model.collections.CollectionEntry;
2626
import org.comixedproject.model.comicbooks.*;
2727
import org.comixedproject.repositories.comicbooks.ComicDetailRepository;
28-
import org.springframework.beans.factory.ObjectFactory;
2928
import org.springframework.beans.factory.annotation.Autowired;
3029
import org.springframework.data.domain.Example;
3130
import org.springframework.data.domain.PageRequest;
@@ -45,9 +44,6 @@
4544
public class ComicDetailService {
4645
@Autowired private ComicDetailRepository comicDetailRepository;
4746

48-
@Autowired
49-
private ObjectFactory<ComicDetailExampleBuilder> comicDetailExampleBuilderObjectFactory;
50-
5147
boolean caseSensitiveFilenames = !SystemUtils.IS_OS_WINDOWS;
5248

5349
@Transactional

‎comixed-services/src/test/java/org/comixedproject/service/comicbooks/ComicDetailExampleBuilderTest.java‎

Lines changed: 0 additions & 147 deletions
This file was deleted.

0 commit comments

Comments
 (0)