Fixed starting the update metadata process not being async [#2503]

mcpierce · mcpierce · commit 76e7821f857f · 2025-10-28T08:37:02.000-04:00
diff --git a/comixed-rest/src/main/java/org/comixedproject/rest/library/LibraryController.java b/comixed-rest/src/main/java/org/comixedproject/rest/library/LibraryController.java
@@ -37,7 +37,10 @@
 import org.comixedproject.model.net.library.PurgeLibraryRequest;
 import org.comixedproject.model.net.library.RemoteLibraryState;
 import org.comixedproject.service.admin.ConfigurationService;
-import org.comixedproject.service.comicbooks.*;
+import org.comixedproject.service.comicbooks.ComicBookException;
+import org.comixedproject.service.comicbooks.ComicBookSelectionException;
+import org.comixedproject.service.comicbooks.ComicBookService;
+import org.comixedproject.service.comicbooks.ComicSelectionService;
 import org.comixedproject.service.library.LibraryException;
 import org.comixedproject.service.library.LibraryService;
 import org.comixedproject.service.library.RemoteLibraryStateService;
@@ -302,7 +305,7 @@ public void updateSelectedComicBooksMetadata(final HttpSession session, final Pr
     final List<Long> selectedComicBookIds =
         this.comicSelectionService.decodeSelections(session.getAttribute(LIBRARY_SELECTIONS));
     log.info("Updating the metadata for {} comic(s): email={}", selectedComicBookIds.size(), email);
-    this.libraryService.updateMetadata(selectedComicBookIds);
+    this.libraryService.updateMetadata(new ArrayList<>(selectedComicBookIds));
     this.comicSelectionService.clearSelectedComicBooks(email, selectedComicBookIds);
     session.setAttribute(
         LIBRARY_SELECTIONS, this.comicSelectionService.encodeSelections(selectedComicBookIds));
diff --git a/comixed-rest/src/test/java/org/comixedproject/rest/library/LibraryControllerTest.java b/comixed-rest/src/test/java/org/comixedproject/rest/library/LibraryControllerTest.java
@@ -33,9 +33,13 @@
 import org.comixedproject.model.net.admin.ClearImageCacheResponse;
 import org.comixedproject.model.net.comicbooks.ConvertComicsRequest;
 import org.comixedproject.model.net.comicbooks.EditMultipleComicsRequest;
-import org.comixedproject.model.net.library.*;
+import org.comixedproject.model.net.library.PurgeLibraryRequest;
+import org.comixedproject.model.net.library.RemoteLibraryState;
 import org.comixedproject.service.admin.ConfigurationService;
-import org.comixedproject.service.comicbooks.*;
+import org.comixedproject.service.comicbooks.ComicBookException;
+import org.comixedproject.service.comicbooks.ComicBookSelectionException;
+import org.comixedproject.service.comicbooks.ComicBookService;
+import org.comixedproject.service.comicbooks.ComicSelectionService;
 import org.comixedproject.service.library.LibraryException;
 import org.comixedproject.service.library.LibraryService;
 import org.comixedproject.service.library.RemoteLibraryStateService;
@@ -80,14 +84,15 @@ class LibraryControllerTest {
   @Mock private JobExecution jobExecution;
   @Mock private EditMultipleComicsRequest editMultipleComicsRequest;
   @Mock private RemoteLibraryState remoteLibraryState;
-  @Mock private List selectedIds;
   @Mock private HttpSession httpSession;
   @Mock private Principal principal;
 
   @Mock
   @Qualifier(EDIT_COMIC_METADATA_JOB)
   private Job editComicMetadataJob;
 
+  private List<Long> selectedIds = new ArrayList<>();
+
   @Captor private ArgumentCaptor<JobParameters> jobParametersArgumentCaptor;
 
   @BeforeEach
@@ -97,6 +102,7 @@ void setUp() throws ComicBookSelectionException {
     Mockito.when(comicSelectionService.decodeSelections(TEST_ENCODED_IDS)).thenReturn(selectedIds);
     Mockito.when(comicSelectionService.encodeSelections(Mockito.anyList()))
         .thenReturn(TEST_REENCODED_IDS);
+    selectedIds.add(TEST_COMIC_BOOK_ID);
   }
 
   @Test
diff --git a/comixed-services/src/main/java/org/comixedproject/service/comicbooks/ComicSelectionService.java b/comixed-services/src/main/java/org/comixedproject/service/comicbooks/ComicSelectionService.java
@@ -41,6 +41,7 @@
 import org.comixedproject.service.user.ComiXedUserException;
 import org.comixedproject.service.user.UserService;
 import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.scheduling.annotation.Async;
 import org.springframework.stereotype.Service;
 
 /**
@@ -203,7 +204,8 @@ public void publishSelections(final String email, final List<Long> selections) {
     this.doPublishSelectionUpdateForUser(email, selections);
   }
 
-  private void doPublishSelectionUpdateForUser(final String email, final List<Long> selections) {
+  @Async
+  protected void doPublishSelectionUpdateForUser(final String email, final List<Long> selections) {
     try {
       final ComiXedUser user = this.userService.findByEmail(email);
       this.publishComicBookSelectionStateAction.publish(
diff --git a/comixed-services/src/main/java/org/comixedproject/service/library/LibraryService.java b/comixed-services/src/main/java/org/comixedproject/service/library/LibraryService.java
@@ -30,6 +30,7 @@
 import org.comixedproject.state.comicbooks.ComicStateHandler;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.context.ApplicationEventPublisher;
+import org.springframework.scheduling.annotation.Async;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 
@@ -68,6 +69,7 @@ public void clearImageCache() throws LibraryException {
    * @param ids the comics
    */
   @Transactional
+  @Async
   public void updateMetadata(final List<Long> ids) {
     log.debug("Preparing {} comic book(s) for metadata update", ids.size());
     this.comicBookService.prepareForMetadataUpdate(ids);
