Fixed not updating the comic state after batch scraping [#2447]

mcpierce · mcpierce · commit 67c90474d868 · 2025-09-19T09:53:42.000-04:00
diff --git a/comixed-batch/src/main/java/org/comixedproject/batch/comicbooks/ScrapeMetadataConfiguration.java b/comixed-batch/src/main/java/org/comixedproject/batch/comicbooks/ScrapeMetadataConfiguration.java
@@ -23,7 +23,7 @@
 import org.comixedproject.batch.comicbooks.listeners.ScrapeMetadataJobListener;
 import org.comixedproject.batch.comicbooks.processors.ScrapeMetadataProcessor;
 import org.comixedproject.batch.comicbooks.readers.ScrapeMetadataReader;
-import org.comixedproject.batch.writers.NoopWriter;
+import org.comixedproject.batch.comicbooks.writers.ScrapeMetadataWriter;
 import org.comixedproject.model.comicbooks.ComicBook;
 import org.springframework.batch.core.Job;
 import org.springframework.batch.core.Step;
@@ -92,7 +92,7 @@ public Step scrapeMetadataStep(
       final PlatformTransactionManager platformTransactionManager,
       final ScrapeMetadataReader reader,
       final ScrapeMetadataProcessor processor,
-      final NoopWriter<ComicBook> writer,
+      final ScrapeMetadataWriter writer,
       final ScrapeMetadataChunkListener chunkListener) {
     return new StepBuilder("scrapeMetadataStep", jobRepository)
         .<ComicBook, ComicBook>chunk(this.chunkSize, platformTransactionManager)
diff --git a/comixed-batch/src/main/java/org/comixedproject/batch/comicbooks/writers/ScrapeMetadataWriter.java b/comixed-batch/src/main/java/org/comixedproject/batch/comicbooks/writers/ScrapeMetadataWriter.java
@@ -0,0 +1,38 @@
+/*
+ * ComiXed - A digital comic book library management application.
+ * Copyright (C) 2025, The ComiXed Project
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses>
+ */
+
+package org.comixedproject.batch.comicbooks.writers;
+
+import lombok.extern.log4j.Log4j2;
+import org.comixedproject.state.comicbooks.ComicEvent;
+import org.springframework.batch.core.configuration.annotation.StepScope;
+import org.springframework.stereotype.Component;
+
+/**
+ * <code>ScrapeMetadataWriter</code> writes the comic books after they have been batch scraped.
+ *
+ * @author Darryl L. Pierce
+ */
+@Component
+@StepScope
+@Log4j2
+public class ScrapeMetadataWriter extends AbstractComicBookWriter {
+  public ScrapeMetadataWriter() {
+    super(ComicEvent.metadataUpdated);
+  }
+}
diff --git a/comixed-batch/src/test/java/org/comixedproject/batch/comicbooks/writers/ScrapeMetadataWriterTest.java b/comixed-batch/src/test/java/org/comixedproject/batch/comicbooks/writers/ScrapeMetadataWriterTest.java
@@ -0,0 +1,50 @@
+/*
+ * ComiXed - A digital comic book library management application.
+ * Copyright (C) 2025, The ComiXed Project
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses>
+ */
+
+package org.comixedproject.batch.comicbooks.writers;
+
+import java.util.ArrayList;
+import org.comixedproject.model.comicbooks.ComicBook;
+import org.comixedproject.state.comicbooks.ComicEvent;
+import org.comixedproject.state.comicbooks.ComicStateHandler;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+import org.mockito.junit.jupiter.MockitoExtension;
+import org.springframework.batch.item.Chunk;
+
+@ExtendWith(MockitoExtension.class)
+class ScrapeMetadataWriterTest {
+  @InjectMocks private ScrapeMetadataWriter writer;
+  @Mock private ComicStateHandler comicStateHandler;
+  @Mock private ComicBook comicBook;
+
+  private Chunk<ComicBook> comicBookList = new Chunk<>(new ArrayList<>());
+
+  @Test
+  void write() {
+    for (int index = 0; index < 25; index++) comicBookList.add(comicBook);
+
+    writer.write(comicBookList);
+
+    Mockito.verify(comicStateHandler, Mockito.times(comicBookList.size()))
+        .fireEvent(comicBook, ComicEvent.metadataUpdated);
+  }
+}
