Fixed story entries, removing the comic vine id field [#2368]

mcpierce · mcpierce · commit 3f72abecc3cc · 2025-05-04T12:23:56.000-04:00
diff --git a/comixed-model/src/main/java/org/comixedproject/model/lists/StoryEntry.java b/comixed-model/src/main/java/org/comixedproject/model/lists/StoryEntry.java
@@ -91,13 +91,6 @@ public class StoryEntry {
   @Setter
   private ComicBook comicBook;
 
-  @Column(name = "comic_vine_id", nullable = true, updatable = true, unique = true)
-  @JsonProperty("comicVineId")
-  @JsonView(View.StoryList.class)
-  @Getter
-  @Setter
-  private Integer comicVineId;
-
   @Override
   public boolean equals(final Object o) {
     if (this == o) return true;
diff --git a/comixed-model/src/main/resources/db/migrations/2.3/020_2368_removed_comic_vine_id_from_story_entries.xml b/comixed-model/src/main/resources/db/migrations/2.3/020_2368_removed_comic_vine_id_from_story_entries.xml
@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<databaseChangeLog xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+                   xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+                   xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.1.xsd">
+    <changeSet id="020_2368_removed_comic_vine_id_from_story_entries.xml" author="mcpierce">
+
+        <preConditions onFail="MARK_RAN">
+            <columnExists tableName="story_entries" columnName="comic_vine_id"/>
+        </preConditions>
+
+        <dropColumn tableName="story_entries" columnName="comic_vine_id"/>
+
+    </changeSet>
+</databaseChangeLog>
diff --git a/comixed-model/src/main/resources/db/migrations/2.3/changelog-2.3.xml b/comixed-model/src/main/resources/db/migrations/2.3/changelog-2.3.xml
@@ -26,5 +26,6 @@
     <include file="/db/migrations/2.3/017_2341_added_publisher_details_view.xml"/>
     <include file="/db/migrations/2.3/018_2346_add_notes_to_displayable_comic_books.xml"/>
     <include file="/db/migrations/2.3/019_2368_stories_reference_metadata_source.xml"/>
+    <include file="/db/migrations/2.3/020_2368_removed_comic_vine_id_from_story_entries.xml"/>
 
 </databaseChangeLog>
diff --git a/comixed-webui/src/app/lists/models/story-entry.ts b/comixed-webui/src/app/lists/models/story-entry.ts
@@ -25,5 +25,4 @@ export interface StoryEntry {
   volume: string;
   issueNumber: string;
   comic: ComicBook;
-  comicVineId: number;
 }

Original file line number	Diff line number	Diff line change
`@@ -25,5 +25,4 @@ export interface StoryEntry {`
`25`	`25`	`volume: string;`
`26`	`26`	`issueNumber: string;`
`27`	`27`	`comic: ComicBook;`
`28`		`- comicVineId: number;`
`29`	`28`	`}`