Fixes #1837 - Handshake fails in CometD 8 on Tomcat 10.#1838
Merged
Conversation
Now all writes are delayed so that they happen from onWritePossible(). The first write is now writing `null` to signal to the implementation to skip the write, store the callback and wait for onWritePossible() to be invoked (due to the fact that setWriteListener() has been called). Signed-off-by: Simone Bordet <[email protected]>
…ion. Signed-off-by: Simone Bordet <[email protected]>
lorban
reviewed
Aug 7, 2024
...-server-http-jakarta/src/main/java/org/cometd/server/http/jakarta/JakartaCometDResponse.java
Show resolved
Hide resolved
lorban
approved these changes
Aug 7, 2024
Collaborator
lorban
left a comment
lorban
left a comment
There was a problem hiding this comment.
LGTM, up to you to modify the comment or not.
Signed-off-by: Simone Bordet <[email protected]>
lorban
approved these changes
Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now all writes are delayed so that they happen from onWritePossible().
The first write is now writing
nullto signal to the implementation to skip the write, store the callback and wait for onWritePossible() to be invoked (due to the fact that setWriteListener() has been called).