PR: Ohno (2013) Correlated Colour Temperature Performance Improvements#951
Merged
PR: Ohno (2013) Correlated Colour Temperature Performance Improvements#951
Conversation
KelSolaar
force-pushed
the
feature/cct_optimisation
branch
from
2534931 to
5acfcae
Compare
…nck_law" definition.
…multi_signals_unpack_data" method.
….uv_to_CCT_Planck1900" definitions.
…colour.CCT_to_uv_Ohno2013" definition by 42500%.
KelSolaar
force-pushed
the
feature/cct_optimisation
branch
from
5acfcae to
f09af99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR dramatically improves the performance of the Ohno (2013) CCT computations by use of caching and vectorised spectral conversion:
colour.uv_to_CCT_Ohno2013is ~100x fastercolour.CCT_to_uv_Ohno2013is ~425x fasterA definition that converts from CCT to CIE UCS colourspace uv chromaticity coordinates using Planck's Law has also been added:
colour.CCT_to_uv_Planck1900Preflight
Code Style and Quality
colour,colour.models.Documentation