PR: Polish *sUCS* colourspace and *sCAM* colour appearance model implementation.#1356
Merged
PR: Polish *sUCS* colourspace and *sCAM* colour appearance model implementation.#1356
Conversation
… transformations (XYZ_to_sUCS, sUCS_to_XYZ) and associated tests. - Add sCAM colour appearance model (XYZ_to_sCAM, sCAM_to_XYZ) and associated tests.
5f48018 to
7509827
Compare
7509827 to
05c7fd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR polishes the work contributed in #1349. Mostly implementation consistency with respect to other CAMs and the reference publication. The sUCS colourspace was split in two so that it returns now rectangular coordinates and two extra definitions are responsible for the transformation to polar coordinates. The chromatic adaptation transform has been extracted to its own definition:
colour.chromatic_adaptation_Li2025.Preflight
Code Style and Quality
colour,colour.models.Documentation