Skip to content

PR: Polish *sUCS* colourspace and *sCAM* colour appearance model implementation.#1356

Merged
KelSolaar merged 10 commits intodevelopfrom
feature/sucs-scam-staging
Jul 17, 2025
Merged

PR: Polish *sUCS* colourspace and *sCAM* colour appearance model implementation.#1356
KelSolaar merged 10 commits intodevelopfrom
feature/sucs-scam-staging

Conversation

@KelSolaar
Copy link
Copy Markdown
Member

@KelSolaar KelSolaar commented Jul 17, 2025

Summary

This PR polishes the work contributed in #1349. Mostly implementation consistency with respect to other CAMs and the reference publication. The sUCS colourspace was split in two so that it returns now rectangular coordinates and two extra definitions are responsible for the transformation to polar coordinates. The chromatic adaptation transform has been extracted to its own definition: colour.chromatic_adaptation_Li2025.

Preflight

Code Style and Quality

  • Unit tests have been implemented and passed.
  • Pyright static checking has been run and passed.
  • Pre-commit hooks have been run and passed.
  • New transformations have been added to the Automatic Colour Conversion Graph.
  • New transformations have been exported to the relevant namespaces, e.g. colour, colour.models.

Documentation

  • New features are documented along with examples if relevant.
  • The documentation is Sphinx and numpydoc compliant.

@KelSolaar KelSolaar added this to the v0.4.7 milestone Jul 17, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 17, 2025

Coverage Status

coverage: 99.346% (+0.004%) from 99.342%
when pulling 05c7fd0 on feature/sucs-scam-staging
into adf021a on develop.

@KelSolaar KelSolaar force-pushed the feature/sucs-scam-staging branch from 5f48018 to 7509827 Compare July 17, 2025 07:52
@KelSolaar KelSolaar force-pushed the feature/sucs-scam-staging branch from 7509827 to 05c7fd0 Compare July 17, 2025 07:55
@KelSolaar KelSolaar merged commit e2f44d8 into develop Jul 17, 2025
43 of 44 checks passed
@KelSolaar KelSolaar deleted the feature/sucs-scam-staging branch July 17, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants