Conversation
Contributor
|
Sometimes the global change from "given" to "specified" makes things read a little oddly, e.g. |
Member
Author
Good catch, fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the docstrings by using Claude 4 via Claude Code.
A few observations:
Was it worth it? I think so! Many small errors were fixed and the quality of the documentation has improved. However, for that particular task, I think it would be better to write a dedicated script that extracts the docstrings using the Python AST and process them by giving the object code and surrounding module code rather than having Claude Code doing the work itself. I was actually looking at whether we could implement a plugin on top of Ruff to do this or twist Pydocstyle's arm a bit!
I will work on something along those lines soon.
The prompt I used is as follows:
Task: Update docstrings in all Python modules within the current sub-package recursively to improve wording and clarity.
Processing Approach:
Mandatory Requirements:
Content Standards:
inRGB``, etc...Restrictions:
Formatting:
Verification Checklist:
Before completing each docstring update, verify:
Preflight
Code Style and Quality
colour,colour.models.Documentation