PR: Add *FilmLight E-Gamut 2*.#1323
Merged
KelSolaar merged 6 commits intocolour-science:developfrom Jan 7, 2025
Merged
Conversation
Contributor
Author
|
I believe that adding the lower tolerance for the XYZ matrix unit test means the tests now pass. This was needed because E-Gamut 2 uses an explicitly defined RGB to XYZ matrix, with six decimal places of precision, rather than a matrix derived from the primaries and white point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the new FilmLight E-Gamut 2 colourspace introduced in Baselight 6. This is a small modification of the original E-Gamut, moving the red and green primaries to enclose AWG4.
Preflight
Code Style and Quality
I apologise that I do not understand the tests sufficiently to run them and fix any errors. GitHub is currently showing CI failures after my commits.
I am happy to be educated on what I should have done!
Documentation
I do not believe any new documentation, other than the included basic docstring is needed