Skip to content

PR: Use shape if passed, to also reshape the colour.continuous.AbstractContinuousSignal sub-classes in colour.colorimetry.sd_to_XYZ_integration definition.#1250

Merged
KelSolaar merged 2 commits intodevelopfrom
sd_to_xyz_integration_shape
Mar 15, 2024
Merged

PR: Use shape if passed, to also reshape the colour.continuous.AbstractContinuousSignal sub-classes in colour.colorimetry.sd_to_XYZ_integration definition.#1250
KelSolaar merged 2 commits intodevelopfrom
sd_to_xyz_integration_shape

Conversation

@KelSolaar
Copy link
Copy Markdown
Member

@KelSolaar KelSolaar commented Mar 12, 2024 •
edited
Loading

Summary

This PR ensures that the shape argument, if passed, is also used to reshape the colour.continuous.AbstractContinuousSignal sub-classes in colour.colorimetry.sd_to_XYZ_integration definition.

References #1247.

Preflight

Code Style and Quality

  • [N/A] Unit tests have been implemented and passed.
  • Pyright static checking has been run and passed.
  • Pre-commit hooks have been run and passed.
  • [N/A] New transformations have been added to the Automatic Colour Conversion Graph.
  • [N/A] New transformations have been exported to the relevant namespaces, e.g. colour, colour.models.

Documentation

  • New features are documented along with examples if relevant.
  • The documentation is Sphinx and numpydoc compliant.

@KelSolaar KelSolaar changed the title PR: Use shape if passed for the colour.continuous.AbstractContinuousSignal sub-classes in colour.colorimetry.sd_to_XYZ_integration definition. PR: Use shape if passed, to also reshape the colour.continuous.AbstractContinuousSignal sub-classes in colour.colorimetry.sd_to_XYZ_integration definition. Mar 12, 2024
@KelSolaar KelSolaar force-pushed the sd_to_xyz_integration_shape branch 2 times, most recently from 9973980 to 329fa57 Compare March 12, 2024 09:55
@KelSolaar
Copy link
Copy Markdown
Member Author

KelSolaar commented Mar 12, 2024

Something is broken, I will take a look tonight!

@tjdcs
Copy link
Copy Markdown
Contributor

tjdcs commented Mar 12, 2024

@KelSolaar While you are looking at this can you also check that the ArrayLike inputs actually get converted to an array before the caching check in sd_to_XYZ? I noticed that if you pass in a list[float] the method fails. I think it just needs an asarray somewhere before calling tobytes() (when xxhash is installed)

@KelSolaar
Use shape if passed, to reshape the `colour.continuous.AbstractCont…
8838a11 
…inuousSignal` sub-classes in `colour.colorimetry.sd_to_XYZ_integration` definition.
@KelSolaar KelSolaar force-pushed the sd_to_xyz_integration_shape branch from 329fa57 to 8838a11 Compare March 13, 2024 05:00
@KelSolaar
Copy link
Copy Markdown
Member Author

KelSolaar commented Mar 13, 2024

Should be done!

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 13, 2024 •
edited
Loading

Coverage Status

coverage: 99.721% (-0.002%) from 99.723%
when pulling f832096 on sd_to_xyz_integration_shape
into 7fb9fcc on develop.

@KelSolaar
Copy link
Copy Markdown
Member Author

KelSolaar commented Mar 15, 2024

Going to merge this one @tjdcs!

@KelSolaar KelSolaar merged commit bb35ab9 into develop Mar 15, 2024
@KelSolaar KelSolaar deleted the sd_to_xyz_integration_shape branch March 15, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KelSolaar @tjdcs @coveralls