PR: Fix incorrect colour.colorimetry.sd_gaussian_fwhm definition output.#1184
Merged
PR: Fix incorrect colour.colorimetry.sd_gaussian_fwhm definition output.#1184
colour.colorimetry.sd_gaussian_fwhm definition output.#1184Conversation
KelSolaar
force-pushed
the
feature/sd_gaussian
branch
from
a2e89cf to
2f51cc6
Compare
Contributor
|
@KelSolaar This is still wrong: from colour.colorimetry.generation import sd_gaussian_fwhm
from colour.colorimetry.spectrum import SPECTRAL_SHAPE_DEFAULT
from colour.plotting.colorimetry import plot_single_sd
from matplotlib import pyplot as plt
center = 500
fwhm = 10
spd = sd_gaussian_fwhm(center,fwhm,SPECTRAL_SHAPE_DEFAULT)
fig, ax = plot_single_sd(spd, standalone=False)
ax.set_xlim(450,550)
ax.set_xticks([center-fwhm, center-fwhm/2, center, center+fwhm/2, center+fwhm])
ax.set_yticks([0,.5,1])
ax.grid(visible=True)
plt.show()
The acronym FWHM is shorthand for "full width at half maximum" meaning at center + half the fwhm, the spd should have a value of 0.5 |
Contributor
|
Ugh.... sorry. My mistake. My local pull to check this didn't go through. 
|
Member
Author
|
I added a unit test to verify the width. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
colour.colorimetry.sd_gaussian_fwhmoutput was not correct as per #1171.Preflight
Code Style and Quality
colour,colour.models.Documentation