PR: Remove ability to pass illuminant in "CIE XYZ" to "CIE xyY" related transformations.#1153
Merged
PR: Remove ability to pass illuminant in "CIE XYZ" to "CIE xyY" related transformations.#1153
Conversation
…ransformations. This is not a CIE recommendation and the choice of what to when null tristimulus values are passed should be given to the user.
Member
Author
|
Merging this one, as it improves consistency across the board, especially with regard to the few other space that do projective transformations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This one has been itching me for a while, it is a very old behaviour that is very strongly opinionated but not recommended by CIE during the computation of chromaticity coordinates: When the tristimulus values are null, we do set the chromaticity coordinates to the passed illuminant ones and the luminance to zero. This is what Bruce Lindbloom is doing. It is quite useful as it means that the achromatic colours are all on the same axis but I reckon that this is a behaviour that should be controlled by the user post-conversion. We do not do that with any other space for that matter.
Preflight
Code Style and Quality
colour,colour.models.Documentation