PR: Implement support for fast integer digest using "xxhash".#1149
Merged
PR: Implement support for fast integer digest using "xxhash".#1149
Conversation
KelSolaar
force-pushed
the
feature/xxhash
branch
3 times, most recently
from
d2f7185 to
17509d8
Compare
tjdcs
approved these changes
May 8, 2023
| return -1 | ||
|
|
||
| else: | ||
| int_digest = hash # pyright: ignore |
Contributor
There was a problem hiding this comment.
Does this line need #pragma: no cover?
Otherwise I don't see any issues and this looks ready to merge.
Member
Author
|
Merged, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements support for fast integer digest using xxhash with the
colour.utilities.int_digestdefinition. Ifxxhashis not available it falls back to the builtinhashdefinition.The main use case is hashing of the
ndarrayas highlighted in PR #1120.Preflight
Code Style and Quality
colour,colour.models.Documentation