Update to COLMAP HEAD #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Eventually, we should introduce a global_mapper option into colmap. This indeed becomes difficult to maintain in the long-term. Meanwhile, I don't think there is an ambition to support multiple versions of colmap. The only use case for not using the FetchContent approach is when one wants to make code changes to both glomap and colmap at the same time. |
|
The intention of this update was to support in glomap the newly introduced camera model (colmap/colmap#2786) and updated undistortion (colmap/colmap#2857) for Fisheye images. This workflow may need to be gone through repeatedly in the future when the base classes are updated. |
ahojnnes
approved these changes
Nov 15, 2024
Contributor
|
Thanks very much @sarlinpe ! |
Collaborator
|
Sorry but I just have time to look into it. Thank you so much @sarlinpe ! |
uptycs-rmack
pushed a commit
to uptycs-rmack/glomap
that referenced
this pull request
Jan 1, 2026
* Update to COLMAP HEAD * Bump COLMAP tag * Install gmock in CI * Apply clang-tidy only to GLOMAP headers * Fix clang-tidy regexp header filter * Make PoseLib a system include
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to colmap/colmap@3254263. I don't know how you want to handle older versions of COLMAP - maybe by creating a new release? Merging this into the COLMAP repos would definitely make this easier.