Repository navigation
Fix IMC 2024 download layout with a relative data path - #4976
Merged
Merged
Conversation
ahojnnes
approved these changes
Nov 8, 2026
ahojnnes
enabled auto-merge (squash)
November 8, 2026 19:53
fringehush-gif
added a commit
to fringehush-gif/colmap
that referenced
this pull request
Nov 8, 2026
Import the upstream IMC 2024 download-layout repair. Relative data paths previously duplicated the dataset directory when moving extracted scenes. ## Upstream commits - bb88176: Fix IMC 2024 download layout with a relative data path (colmap#4976). ## Validation - Windows Python 3.14.10: the exact extracted download_imc2024 function preserves both images from a local ZIP for relative and absolute paths. The old function fails the relative-path case; its absolute-path control passes. - Kaggle invocation and logging were replaced by stand-ins. Full-module import and upstream pytest execution were not run: this interpreter lacks pytest and py7zr. No network downloads, dependency installs or C++ rebuild. AI disclosure: Totally vibe coded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After extracting the competition archive,
download_imc2024joins the dataset path tocategory_patha second time. With--data_path data, the destination becomesdata/imc2024/data/imc2024/train/alland moving the extracted scene fails. Move each scene directly tocategory_pathand identify thealldirectory by its path component on every platform.pytest benchmark/reconstruction/download_test.pypasses on Python 3.12. The test extracts a small local ZIP, stubs only the Kaggle download command, and verifies the image bytes atdata/imc2024/train/all/scene/images/one.jpg. Ruff lint and format checks pass.