Repository navigation
Select PLY output in the PyCOLMAP dense reconstruction tutorial - #4975
Merged
Merged
Conversation
ahojnnes
approved these changes
Nov 8, 2026
ahojnnes
enabled auto-merge (squash)
November 8, 2026 14:17
fringehush-gif
added a commit
to fringehush-gif/colmap
that referenced
this pull request
Nov 8, 2026
…nance) Bring the fork through official COLMAP f0ddf77. Existing implementation families and their qualification remain bound to their recorded source pins. ## Change - Select PLY output in the PyCOLMAP dense reconstruction tutorial. - Remove two unreachable breaks after fatal GTest failures in database tests. ## Upstream commits - 97b5d74 — Select PLY output in the PyCOLMAP dense reconstruction tutorial (colmap#4975) - f0ddf77 — Remove unreachable break statements in database test (colmap#4990) ## Validation - The two-parent merge is conflict-free and changes only the two upstream files. The index and four unrelated working-tree edits remain untouched. - No production C++ changes. No rebuild or native tests were run for this merge. AI disclosure: Totally vibe coded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tutorial names its output
dense.ply, but the Python binding defaults tooutput_type="bin"and passes that path to the binary reconstruction directory writer. Passoutput_type="ply"so readers get the point cloud shown in the example.Tested both calls with PyCOLMAP 4.2.1 on a synthetic PINHOLE reconstruction and an empty fusion configuration. The original call raises the directory error reported in #4280. The updated call writes a file with a PLY header. This addresses that exception independently of how many points a dataset fuses.
Refs #4280.