Repository navigation
Conversation
Contributor
|
I managed to squeeze more performance out of this, so I made a follow-up: #4930.
I would appreciate feedback. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2361.
Add an optional mask_path to image_undistorter and pycolmap.undistort_images for COLMAP workspaces. Masks follow the exact output camera, crop, and resolution of their images, with nearest-neighbor sampling (including large downscales) and lossless grayscale PNG output under masks/<image_name>.png. Already-undistorted and spherical images are supported as well.
Accept the existing image-name-plus-.png convention and the extension-replacement fallback. Require readable, correctly sized masks for selected images; report errors through the controller/Python API and a failed CLI exit status. Other output formats explicitly reject mask_path. Existing calls without masks retain their behavior, and the new Python argument is keyword-only.
Validation on a CPU-only Release build (GUI/CUDA/MVS disabled):
Developed with assistance from OpenAI Codex.