Display CLI floating-point defaults with 3 significant digits #3579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahojnnes
approved these changes
Aug 19, 2025
Contributor
|
Thank you! |
tavislocus
pushed a commit
to tavislocus/colmap_6dof
that referenced
this pull request
Aug 19, 2025
…#3579) Limit floating-point default values in CLI display to 3 significant digits using StringPrintf("%.3g"). Example changes: - `--Mapper.min_focal_length_ratio (=0.10000000000000001)` -> `--Mapper.min_focal_length_ratio (=0.1) ` - `--Mapper.init_max_forward_motion (=0.94999999999999996)` -> `--Mapper.init_max_forward_motion (=0.95) ` - `--SiftExtraction.dsp_min_scale arg (=0.16666666666666666)` -> `--SiftExtraction.dsp_min_scale arg (=0.167)` - `--Example.large_number arg (=500000)` -> `--Example.large_number arg (=5e+05)` - `--Example.small_number arg (=0.00005)` -> `--Example.small_number arg (=5e-05)` Co-authored-by: StonerLing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit floating-point default values in CLI display to 3 significant digits using StringPrintf("%.3g").
Example changes:
--Mapper.min_focal_length_ratio (=0.10000000000000001)->--Mapper.min_focal_length_ratio (=0.1)--Mapper.init_max_forward_motion (=0.94999999999999996)->--Mapper.init_max_forward_motion (=0.95)--SiftExtraction.dsp_min_scale arg (=0.16666666666666666)->--SiftExtraction.dsp_min_scale arg (=0.167)--Example.large_number arg (=500000)->--Example.large_number arg (=5e+05)--Example.small_number arg (=0.00005)->--Example.small_number arg (=5e-05)