Throw exception for Frame::SetRigId when rig pointer is available. #3558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahojnnes
reviewed
Aug 11, 2025
| void Frame::SetRigId(const rig_t rig_id) { | ||
| THROW_CHECK_NE(rig_id, kInvalidRigId); | ||
| THROW_CHECK(!HasRigPtr()); | ||
| rig_id_ = rig_id; |
Contributor
There was a problem hiding this comment.
Alternatively, if the rig has a pointer, we could just check that its ID is consistent?
Contributor
Author
There was a problem hiding this comment.
If the rig has a pointer, it means that the ID has been set before, since setting the pointer requires the ID to be set beforehand. So there are actually no practical cases where we want to set the ID after the pointer.
Also, the current fix is consistent with Image::SetCamreaId and Image::SetFrameId.
ahojnnes
approved these changes
Aug 11, 2025
tavislocus
pushed a commit
to tavislocus/colmap_6dof
that referenced
this pull request
Aug 19, 2025
ahojnnes
pushed a commit
that referenced
this pull request
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To align with
Image::SetCameraIdandImage::SetFrameId.