Throw exception when image.SetFramePtr() sets a frame without the image listed as its data. #3540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the corresponding frame.
B1ueber2y
changed the title
ahojnnes
reviewed
Aug 6, 2025
Contributor
ahojnnes
left a comment
ahojnnes
left a comment
There was a problem hiding this comment.
Thanks, LGTM apart from turning this into an exception instead of a hard crash of the process.
Co-authored-by: Johannes Schönberger <[email protected]>
B1ueber2y
changed the title
B1ueber2y
changed the title
Contributor
Author
Contributor
Author
|
One thing that is still extremely unsafe for the reconstruction class is that, there is no guarantee that all images in |
B1ueber2y
changed the title
B1ueber2y
changed the title
ahojnnes
approved these changes
Aug 7, 2025
B1ueber2y
added a commit
that referenced
this pull request
Aug 7, 2025
…ciated rig. (#3543) As a follow up to #3540 for safety improvement, this PR includes the following fixes: * ``AddFrame`` should not add a frame with empty data as its never useful in the reconstruction. NumData() is added for the frame class. * ``Frame.SetRigPtr`` should set a rig that has all sensors in the frame data supported. * Conversely, when a rig pointer is available for the frame, ``Frame.AddDataId`` should add data that with the sensor available in the associated rig. Related tests are added. --------- Co-authored-by: Johannes Schönberger <[email protected]>
B1ueber2y
added a commit
that referenced
this pull request
Aug 8, 2025
…ame does not exist in the reconstruction. (#3546) Follow up to #3540 and #3543 --------- Co-authored-by: Johannes Schönberger <[email protected]>
tavislocus
pushed a commit
to tavislocus/colmap_6dof
that referenced
this pull request
Aug 19, 2025
…ge listed as its data. (colmap#3540) Otherwise the reconstruction data structure is broken, and the round trip wont write out the images. Seems to catch issues in some of the test construction. --------- Co-authored-by: Johannes Schönberger <[email protected]>
tavislocus
pushed a commit
to tavislocus/colmap_6dof
that referenced
this pull request
Aug 19, 2025
…ciated rig. (colmap#3543) As a follow up to colmap#3540 for safety improvement, this PR includes the following fixes: * ``AddFrame`` should not add a frame with empty data as its never useful in the reconstruction. NumData() is added for the frame class. * ``Frame.SetRigPtr`` should set a rig that has all sensors in the frame data supported. * Conversely, when a rig pointer is available for the frame, ``Frame.AddDataId`` should add data that with the sensor available in the associated rig. Related tests are added. --------- Co-authored-by: Johannes Schönberger <[email protected]>
tavislocus
pushed a commit
to tavislocus/colmap_6dof
that referenced
this pull request
Aug 19, 2025
…ame does not exist in the reconstruction. (colmap#3546) Follow up to colmap#3540 and colmap#3543 --------- Co-authored-by: Johannes Schönberger <[email protected]>
ahojnnes
added a commit
that referenced
this pull request
Aug 22, 2025
…ge listed as its data. (#3540) Otherwise the reconstruction data structure is broken, and the round trip wont write out the images. Seems to catch issues in some of the test construction. --------- Co-authored-by: Johannes Schönberger <[email protected]>
ahojnnes
added a commit
that referenced
this pull request
Aug 22, 2025
…ciated rig. (#3543) As a follow up to #3540 for safety improvement, this PR includes the following fixes: * ``AddFrame`` should not add a frame with empty data as its never useful in the reconstruction. NumData() is added for the frame class. * ``Frame.SetRigPtr`` should set a rig that has all sensors in the frame data supported. * Conversely, when a rig pointer is available for the frame, ``Frame.AddDataId`` should add data that with the sensor available in the associated rig. Related tests are added. --------- Co-authored-by: Johannes Schönberger <[email protected]>
ahojnnes
added a commit
that referenced
this pull request
Aug 22, 2025
…ame does not exist in the reconstruction. (#3546) Follow up to #3540 and #3543 --------- Co-authored-by: Johannes Schönberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the reconstruction data structure is broken, and the round trip wont write out the images.
Seems to catch issues in some of the test construction.