Revert scale changes for metric reconstruction in rig sfm. #3530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onstruction in rig sfm.
Contributor
|
Thanks, I am a bit worried about numerical issues due to repeated multiplication of the relative scale factor. Could we alternatively find the average scale between optimized and original registered rigs? |
Contributor
Author
Done. This new approach will need access to the database cache to get the initial rig extrinsics. |
ahojnnes
reviewed
Aug 5, 2025
ahojnnes
reviewed
Aug 6, 2025
Contributor
ahojnnes
left a comment
ahojnnes
left a comment
There was a problem hiding this comment.
Thank you, LGTM. In the future, we could potentially compute the scaling a bit more robustly but this is a good start.
ahojnnes
reviewed
Aug 7, 2025
ahojnnes
reviewed
Aug 7, 2025
ahojnnes
approved these changes
Aug 7, 2025
tavislocus
pushed a commit
to tavislocus/colmap_6dof
that referenced
this pull request
Aug 19, 2025
Fixes colmap#3529 Can be also concerning for hierarchical pipeline https://github.com/colmap/colmap/blob/main/src/colmap/controllers/hierarchical_pipeline_test.cc#L116.
ahojnnes
pushed a commit
that referenced
this pull request
Aug 22, 2025
Fixes #3529 Can be also concerning for hierarchical pipeline https://github.com/colmap/colmap/blob/main/src/colmap/controllers/hierarchical_pipeline_test.cc#L116.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3529
Can be also concerning for hierarchical pipeline https://github.com/colmap/colmap/blob/main/src/colmap/controllers/hierarchical_pipeline_test.cc#L116.