Pano SFM example improvements and fixes #3503
Conversation
ahojnnes
commented
Jul 21, 2025
ahojnnes
commented
- Adds multi-threading support for pano re-rendering.
- Exposes different tiling mechanisms as CLI options.
- Fixes an issue related to swapping of x/y coordinates. This wasn't an issue before with identical width/height of the re-rendered pano images but otherwise led to incorrect width/height in the output images.
There was a problem hiding this comment.
Thank you! I did not make the rendering multi-threaded because cv2.remap is already multi-threaded and saturates all cores on my machine. Additionally, Python multi-threading only helps with I/O because of the GIL. Does this update really make a difference?
The speedup on my machine is significant (~0.5 x #threads), because of:
|
* Adds multi-threading support for pano re-rendering. * Exposes different tiling mechanisms as CLI options. * Fixes an issue related to swapping of x/y coordinates. This wasn't an issue before with identical width/height of the re-rendered pano images but otherwise led to incorrect width/height in the output images.
|
"Adds multi-threading support for pano re-rendering." It seems like the multi-threading does not work in Windows, and max_workers must be 1, otherwise the processing will stuck silently. |
