Fix a bug affecting feature matching on GPU #3473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahojnnes
approved these changes
Jul 11, 2025
ahojnnes
pushed a commit
that referenced
this pull request
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3465 moved the call to
MaxNumKeypointsfromFeatureMatcherController::Setupto its constructor. Unfortunately, in the automatic reconstructor, the controllers are all created upfront, soMaxNumKeypointsis called when the database is empty and thus returns 0.The proposed fix keeps the logic simple, with the only drawback that
MaxNumKeypointsis called in each worker, which is OK since it's a cheap call.