Skip to content

Refactor feature extraction/matching to support other features #3465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahojnnes merged 109 commits into from
Jul 9, 2025
Merged

Refactor feature extraction/matching to support other features #3465

ahojnnes merged 109 commits into from
Jul 9, 2025

Conversation

@ahojnnes
Copy link
Contributor

@ahojnnes ahojnnes commented Jul 9, 2025

No description provided.

ahojnnes and others added 30 commits December 21, 2024 10:17
@ahojnnes
Add ALIKED/LightGlue feature based on libtorch
a89303a
@ahojnnes
d
1705c16
@ahojnnes
d
64424ab
@ahojnnes
d
88bbfbe
@ahojnnes
d
99a46ca
@ahojnnes
d
a95a0c3
@ahojnnes
d
380716b
@ahojnnes
d
4856e82
@ahojnnes
d
1b887b9
@ahojnnes
d
3156d1a
@ahojnnes
d
1103222
@ahojnnes
d
6ee2b04
@ahojnnes
d
70de0d2
@ahojnnes
d
3cfcaa5
@ahojnnes
d
a6d8619
@ahojnnes
Merge branch 'main' of https://github.com/colmap/colmap into user/jsc…
0fae1b1 
…h/torch-aligked-lightglue
@ahojnnes
Merge branch 'main' of https://github.com/colmap/colmap into user/jsc…
df41fd9 
…h/torch-aligked-lightglue
@ahojnnes
d
c877ae8
@ahojnnes
Merge branch 'main' of https://github.com/colmap/colmap into user/jsc…
676577d 
…h/torch-aligked-lightglue
@ahojnnes
d
28364c5
@ahojnnes
Support enum from string conversion
d79efbc
@ahojnnes
d
ea29d68
@ahojnnes
Merge branch 'user/jsch/enum-from-str' into user/jsch/torch-aligked-l…
864590f 
…ightglue
@ahojnnes
d
65a309b
@ahojnnes
Merge branch 'main' of https://github.com/colmap/colmap into user/jsc…
6c4453d 
…h/torch-aligked-lightglue
@ahojnnes
d
60f770d
@ahojnnes
d
333b4ae
@ahojnnes
d
dca41df
@ahojnnes
Merge branch 'main' of https://github.com/colmap/colmap into user/jsc…
57d4651 
…h/torch-aligked-lightglue
@ahojnnes
d
39c29ee
@ahojnnes ahojnnes requested review from B1ueber2y and sarlinpe July 9, 2025 09:27
sarlinpe
sarlinpe approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@sarlinpe sarlinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

B1ueber2y
B1ueber2y approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@B1ueber2y B1ueber2y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Very clean refactoring! Definitely very helpful for the other PR.

@ahojnnes ahojnnes enabled auto-merge (squash) July 9, 2025 17:18
sarlinpe
sarlinpe reviewed Jul 9, 2025
View reviewed changes
@ahojnnes ahojnnes merged commit a90ecc5 into main Jul 9, 2025
14 checks passed
@ahojnnes ahojnnes deleted the user/jsch/feature-refactor branch July 9, 2025 22:41
@sarlinpe sarlinpe mentioned this pull request Jul 10, 2025
Merged
@harryzwh harryzwh mentioned this pull request Aug 31, 2025
Closed
@BrewTestBot BrewTestBot mentioned this pull request Nov 7, 2025
Merged
@B1ueber2y B1ueber2y mentioned this pull request Dec 29, 2025
Merged
B1ueber2y added a commit that referenced this pull request Dec 30, 2025
@B1ueber2y
Implement AddAndRegisterDefaultEnumOption and propagate to codebase. (#…
7eddd91 
…3903)

This feature was added in #3465 but
never implemented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarlinpe sarlinpe sarlinpe approved these changes

@B1ueber2y B1ueber2y B1ueber2y approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ahojnnes @sarlinpe @B1ueber2y