Skip to content

Fix and improve two-view pose and triangulation angle estimation #3146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahojnnes merged 5 commits into from
Feb 10, 2025
Merged

Fix and improve two-view pose and triangulation angle estimation #3146

ahojnnes merged 5 commits into from
Feb 10, 2025

Conversation

@ahojnnes
Copy link
Contributor

@ahojnnes ahojnnes commented Feb 8, 2025 •
edited
Loading

@ahojnnes ahojnnes marked this pull request as ready for review February 9, 2025 08:52
@ahojnnes ahojnnes changed the title Fix two-view triangulation angle estimation Fix and improve two-view pose and triangulation angle estimation Feb 9, 2025
@ahojnnes ahojnnes enabled auto-merge (squash) February 10, 2025 06:49
@ahojnnes ahojnnes merged commit 69abc71 into main Feb 10, 2025
16 checks passed
@ahojnnes ahojnnes deleted the user/jsch/two-view-geometry-bugfix branch February 10, 2025 07:09
@BrewTestBot BrewTestBot mentioned this pull request Jun 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarlinpe sarlinpe sarlinpe approved these changes

@B1ueber2y B1ueber2y Awaiting requested review from B1ueber2y

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The section in src/colmap/estimators two_view_geometry.cc 392 lines of code why no inverse()

3 participants

@ahojnnes @sarlinpe