-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add code coverage reporting #3126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sarlinpe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. As a follow up, one could post a summary of the coverage as PR comment using https://github.com/marocchino/sticky-pull-request-comment There are GH actions that handle the conversion from XML to Markdown, e.g. https://github.com/marketplace/actions/code-coverage-summary
|
@sarlinpe The idea about reporting to the PR is a nice one. However, it's not too useful as implemented by the github actions, because it doesn't perform a diff on the changed files and report the coverage specifically for those. WDYT? |
|
|
Agree, diffs would be more informative but this requires knowing the coverage at head - where would we get this? fetching the artifact from the latest CI run on head? Sounds complicated. |
Uh oh!
There was an error while loading. Please reload this page.