Skip to content

Conversation

@ahojnnes
Copy link
Contributor

@ahojnnes ahojnnes commented Jan 26, 2025

image

Copy link
Member

@sarlinpe sarlinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahojnnes
Copy link
Contributor Author

@sarlinpe The idea about reporting to the PR is a nice one. However, it's not too useful as implemented by the github actions, because it doesn't perform a diff on the changed files and report the coverage specifically for those. WDYT?

@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
src.colmap.controllers 24% 10%
src.colmap.estimators 92% 35%
src.colmap.exe 0% 0%
src.colmap.feature 89% 31%
src.colmap.geometry 96% 36%
src.colmap.image 57% 22%
src.colmap.math 96% 29%
src.colmap.mvs 19% 8%
src.colmap.optim 93% 30%
src.colmap.retrieval 86% 33%
src.colmap.scene 88% 31%
src.colmap.sensor 96% 44%
src.colmap.sfm 84% 40%
src.colmap.ui 0% 0%
src.colmap.util 81% 25%
Summary 68% (30080 / 44448) 26% (27962 / 107259)

@sarlinpe
Copy link
Member

Agree, diffs would be more informative but this requires knowing the coverage at head - where would we get this? fetching the artifact from the latest CI run on head? Sounds complicated.

@ahojnnes ahojnnes enabled auto-merge (squash) January 26, 2025 20:11
@ahojnnes ahojnnes merged commit 9375419 into main Jan 26, 2025
16 checks passed
@ahojnnes ahojnnes deleted the user/jsch/code-cov branch January 26, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants