-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add binding support for invalid values in pycolmap id types #3072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Example: |
|
On the other hand, I have made several attempts to improve the doc rendering of Image class (e.g., B1ueber2y@e205e62). But no luck so far. |
|
Thanks. Nit: For consistency across Python, I would suggest calling it |
Thanks. I have updated the names to upper cases. Now the |
You need to replace "camera_id"_a = kInvalidCameraId,by py::arg_v("camera_id", kInvalidCameraId, "pycolmap.INVALID_CAMERA_ID"),and so on. |
Thanks. Updated. |
sarlinpe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, can you also update this one?
colmap/src/pycolmap/scene/point2d.cc
Line 28 in cd97b65
| "point3D_id"_a = kInvalidPoint3DId) |
I think this was already updated? |
|
I missed it, sorry. |
) Fixes: colmap#3070 Per discussion from colmap#3071
Fixes: #3070
Per discussion from #3071