Add back some ceres bindings to use pycolmap bundle adjustment without pyceres #2985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
One would still need pyceres if the customized pycolmap cost functions and manifolds are needed, but this is a demand that only makes sense when the user is using pyceres to set up the problem. |
ahojnnes
approved these changes
Dec 3, 2024
sarlinpe
approved these changes
Dec 4, 2024
ahojnnes
added a commit
that referenced
this pull request
Dec 6, 2024
…t pyceres (#2985) Relevant discussion here: #2978 No need for ``import ceres`` in ``custom_bundle_adjustment.py`` anymore (relevant discussion: #2896) --------- Co-authored-by: Johannes Schönberger <[email protected]>
HernandoR
pushed a commit
to HernandoR/colmap
that referenced
this pull request
Dec 30, 2024
…t pyceres (colmap#2985) Relevant discussion here: colmap#2978 No need for ``import ceres`` in ``custom_bundle_adjustment.py`` anymore (relevant discussion: colmap#2896) --------- Co-authored-by: Johannes Schönberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant discussion here: #2978
No need for
import ceresincustom_bundle_adjustment.pyanymore (relevant discussion: #2896)