Fix find_package logic for poselib in support of homebrew/vcpkg #2971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Chen <[email protected]>
ahojnnes
reviewed
Dec 2, 2024
ahojnnes
reviewed
Dec 2, 2024
Contributor
|
Thank for you updating the formulas in homebrew, this is great. |
ahojnnes
changed the title
ahojnnes
approved these changes
Dec 2, 2024
Contributor
Author
|
Thanks @ahojnnes for the help in here. 🙏 |
Contributor
|
Thanks for updating the formula on homebrew! @chenrui333 |
ahojnnes
added a commit
that referenced
this pull request
Dec 6, 2024
👋 add build patch to build against system poselib. relates to Homebrew/homebrew-core#199371 --------- Signed-off-by: Rui Chen <[email protected]> Co-authored-by: Johannes Schönberger <[email protected]>
HernandoR
pushed a commit
to HernandoR/colmap
that referenced
this pull request
Dec 30, 2024
…ap#2971) 👋 add build patch to build against system poselib. relates to Homebrew/homebrew-core#199371 --------- Signed-off-by: Rui Chen <[email protected]> Co-authored-by: Johannes Schönberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 add build patch to build against system poselib.
relates to Homebrew/homebrew-core#199371