Fix missing camera ptr for Reconstruction.DeleteAllPoints2DAndPoints3D() #2779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is it possible to construct a test case that covers the issue? Thanks for the fix. |
Contributor
Author
Added some tests in the reconstruction class (we need to add some pipeline tests in the future). PTAL when time permits. The point_triangulator breaks in the current head so we should merge this PR ASAP : ) |
ahojnnes
reviewed
Sep 11, 2024
Contributor
ahojnnes
left a comment
ahojnnes
left a comment
There was a problem hiding this comment.
Thanks, small suggestion. Otherwise, LGTM.
ahojnnes
approved these changes
Sep 11, 2024
ahojnnes
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2775. Missed from #2762