Skip to content

Fix little/big endian detection #2768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahojnnes merged 1 commit into from
Sep 10, 2024
Merged

Fix little/big endian detection #2768

ahojnnes merged 1 commit into from
Sep 10, 2024

Conversation

@ahojnnes
Copy link
Contributor

@ahojnnes ahojnnes commented Sep 10, 2024

This PR fixes two issues:

  1. Adds missing boost includes to define the endian macros. Moves the implementation to the .cc file so we don't transitively propagate the boost includes.
  2. The boost endian macros have been renamed from BOOST_*_ENDIAN to BOOST_ENDIAN_*_BYTE.

@ahojnnes ahojnnes merged commit 7dea0d4 into main Sep 10, 2024
@ahojnnes ahojnnes deleted the user/joschonb/boost-byte-ordering branch September 10, 2024 09:56
@BrewTestBot BrewTestBot mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarlinpe sarlinpe sarlinpe approved these changes

@B1ueber2y B1ueber2y Awaiting requested review from B1ueber2y

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahojnnes @sarlinpe