Skip to content

Report errors in import_images #2750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sarlinpe merged 5 commits into from
Sep 5, 2024
Merged

Report errors in import_images #2750

sarlinpe merged 5 commits into from
Sep 5, 2024

Conversation

@sarlinpe
Copy link
Member

@sarlinpe sarlinpe commented Sep 4, 2024 •
edited
Loading

  • report the name of the image when importing in results in an error
  • add ImageReader::Status::MASK_ERROR to better debug issues with masks (recurrent for many users)
  • For pycolmap.import_images, we could also throw an exception instead of LOG(ERROR)

@sarlinpe sarlinpe mentioned this pull request Sep 4, 2024
Closed
@sarlinpe sarlinpe marked this pull request as ready for review September 4, 2024 20:38
@sarlinpe sarlinpe requested a review from ahojnnes September 4, 2024 20:38
@sarlinpe sarlinpe enabled auto-merge (squash) September 4, 2024 22:00
@sarlinpe sarlinpe merged commit 689e85b into main Sep 5, 2024
@sarlinpe sarlinpe deleted the sarlinpe/imaport-images-error branch September 5, 2024 09:41
@BrewTestBot BrewTestBot mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahojnnes ahojnnes ahojnnes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sarlinpe @ahojnnes