Skip to content

Write out options to ini in full precision, relax bundle adjuster convergence #2713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahojnnes merged 1 commit into from
Aug 15, 2024
Merged

Write out options to ini in full precision, relax bundle adjuster convergence #2713

ahojnnes merged 1 commit into from
Aug 15, 2024

Conversation

@ahojnnes
Copy link
Contributor

@ahojnnes ahojnnes commented Aug 15, 2024 •
edited
Loading

Addresses #2703

  • Make sure we write out parameters in full precision, so small values do not get truncated to 0.
  • Conservatively relax the bundle adjustment convergence thresholds. Before this PR, bundle adjustment would always run for the full iterations because of 0 tolerances.

ahojnnes
ahojnnes commented Aug 15, 2024
View reviewed changes
@ahojnnes ahojnnes enabled auto-merge (squash) August 15, 2024 11:17
@ahojnnes ahojnnes merged commit a3b950c into main Aug 15, 2024
@ahojnnes ahojnnes deleted the user/joschonb/options-bundle-adjuster branch August 15, 2024 11:35
@BrewTestBot BrewTestBot mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@B1ueber2y B1ueber2y B1ueber2y approved these changes

@mihaidusmanu mihaidusmanu Awaiting requested review from mihaidusmanu

@sarlinpe sarlinpe Awaiting requested review from sarlinpe

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahojnnes @B1ueber2y