Fix: sequential matcher overlap number should be inclusive #2701
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug dates back to commit
Improve code of feature matchers
According to this doc in
colmap/src/colmap/controllers/feature_matching.h:As described in the above doc, also intruitively, If we give overlap
3for sequential matcher, without thequadraticoption, the image id100should be matched to97,98,99, and101,102,103, which incluses97,103.